Skip to content

Various SOS, dotnet-dump and documentation fixes - #1355

Merged
mikem8361 merged 5 commits into
dotnet:masterfrom
mikem8361:miscfixes
Jul 17, 2020
Merged

mikem8361 merged 5 commits into
dotnet:masterfrom
mikem8361:miscfixes

Conversation

@mikem8361

Copy link
Copy Markdown
Contributor

Remove some tabs

Fix a CurrentThread being nullable problem

Fix gallery manifest Linux trigger

Fix clrthreads OSID width for longer ids on xplat

Fix error messages and documentation

Add aks.ms link to diagnostics FAQ in SOS error messages
Issue: #1339

Clarify x-plat dump debugging support
Issue: #1247

Mike McLaughlin added 4 commits July 15, 2020 10:12
Remove some tabs

Fix a CurrentThread being nullable problem
Add aks.ms link to diagnostics FAQ in SOS error messages

Issue: dotnet#1339

Clarify x-plat dump debugging support

Issue: dotnet#1247
@mikem8361 mikem8361 self-assigned this Jul 16, 2020
@mikem8361
mikem8361 requested a review from hoyosjs July 16, 2020 22:48

@hoyosjs hoyosjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits here and there. but overall looks good.

Comment thread documentation/FAQ.md Resolved
Comment thread documentation/FAQ.md Resolved
Comment thread src/SOS/SOS.Hosting/SOSHost.cs Resolved
Comment thread src/SOS/SOS.Hosting/SOSHost.cs Resolved
Comment thread src/SOS/Strike/exts.h Resolved
@mikem8361
mikem8361 merged commit f63dc82 into dotnet:master Jul 17, 2020
@mikem8361
mikem8361 deleted the miscfixes branch July 17, 2020 01:26
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants