Repository navigation
Various SOS, dotnet-dump and documentation fixes - #1355
Merged
Merged
Conversation
added 4 commits
July 15, 2020 10:12
Remove some tabs Fix a CurrentThread being nullable problem
Add aks.ms link to diagnostics FAQ in SOS error messages Issue: dotnet#1339 Clarify x-plat dump debugging support Issue: dotnet#1247
hoyosjs
approved these changes
Jul 16, 2020
hoyosjs
left a comment
Member
There was a problem hiding this comment.
Nits here and there. but overall looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some tabs
Fix a CurrentThread being nullable problem
Fix gallery manifest Linux trigger
Fix clrthreads OSID width for longer ids on xplat
Fix error messages and documentation
Add aks.ms link to diagnostics FAQ in SOS error messages
Issue: #1339
Clarify x-plat dump debugging support
Issue: #1247