Repository navigation
Add System.Net.Http and Kestrel counters to list of well-known counters - #1365
Merged
Merged
Conversation
josalem
approved these changes
Jul 20, 2020
josalem
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Should we qualify in the help text counters that only exit in .NET 5.0+, so that users aren't confused when they show as 0 for 3.1 apps?
Contributor
Author
I think that's a really good idea. We can probably add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1188