Skip to content

Add System.Net.Http and Kestrel counters to list of well-known counters - #1365

Merged
sywhang merged 1 commit into
dotnet:masterfrom
sywhang:dev/suwhang/1188
Jul 20, 2020
Merged

sywhang merged 1 commit into
dotnet:masterfrom
sywhang:dev/suwhang/1188

Conversation

@sywhang

@sywhang sywhang commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

Related issue: #1188

@josalem josalem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we qualify in the help text counters that only exit in .NET 5.0+, so that users aren't confused when they show as 0 for 3.1 apps?

@sywhang

sywhang commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

Should we qualify in the help text counters that only exit in .NET 5.0+, so that users aren't confused when they show as 0 for 3.1 apps?

I think that's a really good idea. We can probably add a --version flag to the list command to separate out the list of counters that exist in different versions... Let me create a separate issue for that.

@sywhang
sywhang merged commit 77aeaa0 into dotnet:master Jul 20, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants