Repository navigation
Backport some changes to release - #5968
Merged
Merged
Conversation
hoyosjs
commented
Aug 19, 2026
Member
- Port 8a2daa6 to release branch
- Constrain GetExport RuntimeInfo dereference to module bounds in dbgshim (Constrain GetExport RuntimeInfo dereference to module bounds in dbgshim #5919)
- Refactor build pipeline to separate test jobs (Refactor build pipeline to separate test jobs #5875)
- Fix infinite loop in Repl (Fix infinite loop in Repl #5882)
…im (dotnet#5919) GetTargetCLRMetrics dereferenced the DotNetRuntimeInfo export returned by PEDecoder::GetExport without verifying the whole RuntimeInfo struct lies within the module. Add a CheckRva over sizeof(RuntimeInfo) before reading it, matching the existing bounds checks on the engine-metrics path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This PR changes diagnostics CI from "build and test in every leg" to "build once, then run separate test legs from published artifacts". New state: - the `build` stage produces the binaries/debuggees/test assets once - the `test` stage depends on those build jobs and runs tests from downloaded artifacts - it also installs the appropriate SDKs - tools stay on **net8**, but unit tests move to **net10** to avoid installing more runtimes. - a couple of overly noisy MSBuild messages are downgraded - `diagnostics.yml` and `eng/pipelines/build.yml` now model build and test as separate stages/jobs. Build legs publish `TestArtifacts_*`; test-only legs download them and run `test.cmd`/`test.sh`. - Build legs now publish `bin/**`, `obj/**`, and `test/**` so test legs can run from prebuilt outputs. - `eng/build.ps1` / `eng/build.sh` explicitly install test runtimes on `-skipmanaged` legs and pass `SkipTestArtifactsBuild=true` so debuggees are not rebuilt there. - `eng/TraversalOverrides.targets` is imported after the Traversal SDK and clears `TestDependsOn` when `SkipTestArtifactsBuild=true`. That is the key fix that actually stops implicit build-before-test. - `src/tests/dirs.proj` skips `BuildDebuggees` on those prebuilt test legs. - Test TFMs now use `$(NetCoreAppTestTargetFramework)` (`net10.0`) while tool TFMs remain `$(NetCoreAppMinTargetFramework)` (`net8.0`), which lets us drop the extra net8 test runtime install from `global.json`. - `global.json` keeps an x86 runtime, but now at net10, so Arcade can launch an x86 host on the x86 leg. - `EventLogsPipelineUnitTests` replaces `reader.EndOfStream` assertions with `ReadToEndAsync()` checks so those tests remain stable on the newer runtime. - Logging cleanup: - `eng/AuxMsbuildFiles/SdkPackOverrides.targets`: `High -> Low` (from - `src/tests/SOS.UnitTests/Debuggees/Directory.Build.targets`: skip message lowered --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Using ReadLine + IsNullOrEmpty + continue:
```C#
string line = Console.ReadLine();
if (string.IsNullOrEmpty(line))
continue;
```
Produces an infinite loop if stdin was closed. For example, running
under an llm and it closes the pipe to the tool.
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hoyosjs
enabled auto-merge
August 19, 2026 07:29
noahfalk
previously approved these changes
Aug 19, 2026
steveisok
approved these changes
Aug 19, 2026
Member
Author
|
/ba-g all failures are in restore - not in SOS or tool infra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.