Skip to content

Reduce SOS test debugger churn with session leases - #6260

Merged
max-charlamb merged 2 commits into
mainfrom
dev/max-charlamb/sos-test-session-leases
Nov 19, 2026
Merged

max-charlamb merged 2 commits into
mainfrom
dev/max-charlamb/sos-test-session-leases

Conversation

@max-charlamb

@max-charlamb max-charlamb commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

Hold the existing debugger-session lease across the command sequences in 15 expensive SOS test methods.

Dump sessions share bounded debugger slots. Acquiring the slot separately for every command allows another test to evict the loaded debugger between commands in the same test. Holding AcquireDebuggerSession() across the synchronous sequence avoids that churn.

The change is 15 added lines across 10 test files. Each lease is acquired after navigation and released before any subsequent navigation or await. In GcWhere_Moves, each generation's inspection has its own lease. Live targets retain their existing behavior because their lease is a no-op.

No test cases, matrix coverage, pool sizes, or scheduling behavior are changed. The temporary profiling instrumentation and the larger locality-queue prototype are not included.

Experimental Linux arm64 parallelism

This draft run removes the Linux arm64-specific --max-threads 1 override so the SOS tests use the Helix runner default. The original Linux arm64 restriction remains retained for Linux musl.

SOS Helix timing

Timing includes only SOS Helix work items. It sums the work-item durations across the Framework, .NET 8, 10, 11, and 12 bins for each architecture. Queue time and non-SOS work items are excluded.

Queue Updated run 1688667 Previous run 1688123 Change
Windows x64 36m 36s 41m 17s 11.3% faster
Windows arm64 42m 18s 43m 37s 3.0% faster
Windows x86 36m 17s 39m 17s 7.6% faster
Linux x64 33m 21s 34m 32s 3.4% faster
Linux arm64 27m 23s 39m 16s 30.2% faster
macOS arm64 27m 52s 28m 13s 1.2% faster

Updated run: 1688667

Previous comparable run: 1688123

The Linux arm64 improvement is substantial and consistent with the change removing the one-thread restriction. The remaining queues show smaller gains, likely because session leasing is exercised less heavily or is diluted by the larger SOS matrix.

Keep the existing per-session lease across synchronous SOS command sequences to reduce pooled debugger eviction between commands. Preserve all test coverage and scheduling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4492c22e-8f9c-494f-a4fa-dfc6633e0a0f
@max-charlamb
max-charlamb requested a review from a team as a code owner November 18, 2026 18:49
@max-charlamb

Copy link
Copy Markdown
Member Author

/ba-g unrelated flaky test

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 47047b77-8626-4094-a4bf-e5af02000254
@max-charlamb
max-charlamb marked this pull request as ready for review November 18, 2026 23:59
@max-charlamb
max-charlamb enabled auto-merge (squash) November 19, 2026 00:00
@max-charlamb

max-charlamb commented Nov 19, 2026 •

Copy link
Copy Markdown
Member Author

@max-charlamb
max-charlamb merged commit 6beef19 into main Nov 19, 2026
16 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants