Repository navigation
Reduce SOS test debugger churn with session leases - #6260
Merged
Merged
Conversation
Keep the existing per-session lease across synchronous SOS command sequences to reduce pooled debugger eviction between commands. Preserve all test coverage and scheduling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4492c22e-8f9c-494f-a4fa-dfc6633e0a0f
Member
Author
|
/ba-g unrelated flaky test |
hoyosjs
approved these changes
Nov 18, 2026
steveisok
approved these changes
Nov 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47047b77-8626-4094-a4bf-e5af02000254
max-charlamb
marked this pull request as draft
November 18, 2026 20:19
rcj1
approved these changes
Nov 18, 2026
max-charlamb
marked this pull request as ready for review
November 18, 2026 23:59
max-charlamb
enabled auto-merge (squash)
November 19, 2026 00:00
5 tasks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hold the existing debugger-session lease across the command sequences in 15 expensive SOS test methods.
Dump sessions share bounded debugger slots. Acquiring the slot separately for every command allows another test to evict the loaded debugger between commands in the same test. Holding
AcquireDebuggerSession()across the synchronous sequence avoids that churn.The change is 15 added lines across 10 test files. Each lease is acquired after navigation and released before any subsequent navigation or
await. InGcWhere_Moves, each generation's inspection has its own lease. Live targets retain their existing behavior because their lease is a no-op.No test cases, matrix coverage, pool sizes, or scheduling behavior are changed. The temporary profiling instrumentation and the larger locality-queue prototype are not included.
Experimental Linux arm64 parallelism
This draft run removes the Linux arm64-specific
--max-threads 1override so the SOS tests use the Helix runner default. The original Linux arm64 restriction remains retained for Linux musl.SOS Helix timing
Timing includes only SOS Helix work items. It sums the work-item durations across the Framework, .NET 8, 10, 11, and 12 bins for each architecture. Queue time and non-SOS work items are excluded.
Updated run: 1688667
Previous comparable run: 1688123
The Linux arm64 improvement is substantial and consistent with the change removing the one-thread restriction. The remaining queues show smaller gains, likely because session leasing is exercised less heavily or is diluted by the larger SOS matrix.