Repository navigation
Add some documentation for System.Threading.Lock APIs - #9912
Merged
Merged
Conversation
5 of 8 tasks
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
reviewed
May 14, 2024
gewarren
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding these.
Address feedback Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Contributor
Author
|
Thanks! I believe I've address all of the feedback, also adjusted a couple of things in the latest commit. |
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
reviewed
May 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Learn Build status updates of commit 14dee1b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
gewarren
approved these changes
May 17, 2024
gewarren
reviewed
May 17, 2024
gewarren
enabled auto-merge (squash)
May 22, 2024 03:13
|
Learn Build status updates of commit 6d46e61: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LockandLock+Scopetypes and their APIsRequiresPreviewFeaturesattribute onLock, add test using thelockkeyword runtime#102222RequiresPreviewFeaturesattribute onLock, the relevant code change is in that PR