Repository navigation
[release/11.0] Fix SQL Server JSON index test - #39176
Merged
Merged
Conversation
- Remove unsupported uniqueness from the JSON index test - Match the existing test on main Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused test-only change correctly removes an option rejected by SQL Server JSON-index validation.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns the SQL Server JSON-index migration test with supported non-unique index behavior.
Changes:
- Removes unsupported
.IsUnique()configuration. - Renames the test accordingly.
| File | Description |
|---|---|
test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs |
Updates the JSON-index test to use supported SQL Server configuration. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
AndriySvyryd
approved these changes
Oct 5, 2026
Code Coverage OverviewLanguages: C# C# / code-coverageThe overall line coverage in commit 1b33891 in the Show a line coverage summary of the most impacted files.
Updated |
wtgodbe
added a commit
that referenced
this pull request
Oct 7, 2026
* [release/10.0]: Bump Grpc.AspNetCore from 2.83.0 to 2.84.0 (#39141) --- updated-dependencies: - dependency-name: Grpc.AspNetCore dependency-version: 2.84.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [release/10.0]: Bump OpenTelemetry.Exporter.InMemory from 1.19.0 to 1.19.1 (#39143) --- updated-dependencies: - dependency-name: OpenTelemetry.Exporter.InMemory dependency-version: 1.19.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [release/10.0]: Bump Microsoft.Azure.Cosmos from 3.63.1 to 3.63.2 (#39142) * [release/10.0] Fix Contains handling for read-only collections (#39114) Fixes #38671 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com> * [release/10.0] Update stale nested complex collection entries during Update on a shortened collection (#39092) Fixes #39073 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com> * [release/11.0] Update xUnit v3 to 4.0.1 (#39144) Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com> * Fix SQL Server JSON index test on release/11.0 (#39176) - Remove unsupported uniqueness from the JSON index test - Match the existing test on main Co-authored-by: Will Godbe <willgodbe@Wills-MacBook-Pro.local> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com> Co-authored-by: Andriy Svyryd <Andriy.Svyryd@microsoft.com> Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com> Co-authored-by: William Godbe <wigodbe@microsoft.com> Co-authored-by: Will Godbe <willgodbe@Wills-MacBook-Pro.local> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The release/11.0 backport in #39089 added
.IsUnique()to a JSON-index test after #39090 made that option invalid.mainuses a non-unique index; this aligns the release test withmain.Customer impact
No runtime change. The invalid test blocks SQL Server 2025 CI on unrelated PRs; there is no workaround without changing or skipping the test.
How found
SQL Server 2025 CI failures on #39152–#39156.
Regression
Test-only release-branch mismatch introduced by #39089;
mainis unaffected.Testing
One existing test modified.
. ./restore.sh && . ./activate.sh && dotnet build test/EFCore.SqlServer.FunctionalTests/EFCore.SqlServer.FunctionalTests.csproj --no-restore --verbosity quiet— passed.. ./activate.sh && dotnet exec artifacts/bin/EFCore.SqlServer.FunctionalTests/Debug/net11.0/Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll --filter-method '*Create_json_index_over_complex_property_member' --ignore-exit-code 8— discovered 1 test, skipped locally (SQL Server 2025 unavailable).Risk
Extremely low: two test-only lines; no quirk applicable.