Skip to content

Blockstructure Issues #2431

Open
Open

Description

@cloudRoutine
  • when a source file starts with module instead of namespace there should be no structure line for that module declaration

  • as should not have a blockstructure line

  • blockstructure line shouldn't be under type accessibility modifier

but only sometimes

  • line should be under type or and not under attribute

  • collapse hint doesn't include open

  • collapse block includes type signature

  • do within a match case

Related information

VS 2017 with VisualFSharpOpenSource.vsix built off of master @ 331dde6

Activity

  1. added this to the milestone on Feb 14, 2017
  2. added
    Impact-Medium(Internal MS Team use only) Describes an issue with moderate impact on existing code.
    on Mar 14, 2017
  3. modified the milestones: , 16.0 on Jun 20, 2018
  4. modified the milestones: 16.0, 16.1 on Feb 21, 2019
  5. modified the milestones: 16.1, 16.2 on Apr 23, 2019
  6. modified the milestones: 16.2, Backlog on Apr 30, 2019
  7. github-actions commented on Oct 6, 2026

    @github-actions
    Contributor

    🤖 This is an automated response from Repo Assist.

    I removed AI-thinks-windows-only: the guideline and collapse spans listed here are calculated by the cross-platform FCS ServiceStructure.getOutliningRanges API, which exposes both the full Range and CollapseRange. On current commit d16ac1bc6d29afc0652787af2814ac4d6863a9d9 (2026-10-05), all 42 StructureTests passed on Linux and directly assert source ranges for modules, types, opens, match clauses, and related constructs. This is a classification correction, not a claim that every scenario in the issue is fixed.

    Fresh compiler used: F# Interactive 15.2.200.0, F# 11.2, FSharp.Core 11.0.0.0, .NET 11.0.0-rc.1.26420.103, Linux x64.

    Warning

    Firewall blocked 2 domains

    The following domains were blocked by the firewall during workflow execution:

    • southcentralus0.in.applicationinsights.azure.com
    • userimages.githubusercontent.com

    To allow these domains, add them to the network.allowed list in your workflow frontmatter:

    network:
      allowed:
        - defaults
        - "southcentralus0.in.applicationinsights.azure.com"
        - "userimages.githubusercontent.com"

    See Network Configuration for more information.

    Generated by 🌈 Repo Assist, see workflow run. Learn more.

    Add this agentic workflows to your repo

    To install this agentic workflow, run

    gh aw add githubnext/agentics/workflows/repo-assist.md@7c7feb61a52b662eb2089aa2945588b7a200d404
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-LangService-BlockStructurethose block structure lines and the FCS API that produces themBugImpact-Medium(Internal MS Team use only) Describes an issue with moderate impact on existing code.

    Type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions