Skip to content

Arbitrary nonsense attributes can be added to type extensions #7394

Closed
#7481
Closed
Arbitrary nonsense attributes can be added to type extensions#7394
#7481
Labels
Bug
Milestone
16.5

Description

@cartermp
cartermp
opened on Aug 14, 2019

Consider the following:

open System

[<Hello.my.name.is.Don.Syme>]
type String with
    member this.Doot() = this.Length

image

This should emit an error.

Activity

  1. cartermp
    added
    Bug
    Area-Compiler
    on Aug 14, 2019

  2. dsyme commented on Aug 16, 2019

    @dsyme
    dsyme
    on Aug 16, 2019
    Contributor

    Yup

  3. cartermp
    added this to the Backlog milestone on Aug 16, 2019

  4. KevinRansom commented on Sep 4, 2019

    @KevinRansom
    KevinRansom
    on Sep 4, 2019
    Contributor

    @cartermp, @dsyme.

    Theoretically this is a breaking change. Given that the attributes are garbage, we should be prepared to tell developers to fix their code. If they see the error.

    Kevin

  5. cartermp commented on Sep 4, 2019

    @cartermp
    cartermp
    on Sep 4, 2019
    ContributorAuthor

    Agreed

  6. cartermp
    closed this as completedin #7481on Sep 4, 2019
  7. cartermp
    modified the milestones: Backlog, 16.5 on Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions