Skip to content

Respond to PR code review comments for ported library System.Security.AccessControl #15934

Closed

Description

@venkat-raman251

@GiriSr as the owner of the System.Security.AcessControl library can you please have a look through the code review comments provided in dotnet/corefx#4977 and address them appropriately.

Activity

  1. changed the title [-]Refactoring System.Security.AccessControl[/-] [+]Respond to PR code review comments for ported library System.Security.AccessControl[/+] on Dec 18, 2015
  2. venkat-raman251 commented on Dec 28, 2015

    @venkat-raman251
    ContributorAuthor

    Please address/remove the TODO's in the code.

  3. venkat-raman251 commented on Jan 12, 2016

    @venkat-raman251
    ContributorAuthor

    @weshaggard : Who is the owner of this library to assign this issue to? And is this for rc2?

  4. weshaggard commented on Jan 13, 2016

    @weshaggard
    Member

    @GiriSr is the owner and I don't think this is needed for RC2 it is just clean-up.

  5. venkat-raman251 commented on Jan 13, 2016

    @venkat-raman251
    ContributorAuthor

    @weshaggard : @GiriSr hasn't been active on github from what i can see. That was the reason this was assigned back to me.

  6. Clockwork-Muse commented on Feb 14, 2016

    @Clockwork-Muse
    Contributor

    Additionally, there appears to be no .sln file, and no tests.

  7. niemyjski commented on Jul 25, 2016

    @niemyjski

    What's the status of this?

  8. 3 remaining items

  9. transferred this issue fromdotnet/corefxon Jan 31, 2020
  10. added this to the Future milestone on Jan 31, 2020
  11. removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 7, 2020
  12. niemyjski commented on Jan 7, 2025

    @niemyjski

    bump

  13. self-assigned this
    on Jun 19, 2026
  14. added
    in-prThere is an active PR which will close this issue when it is merged
    on Jun 19, 2026
  15. added a commit that references this issue on Jun 23, 2026
  16. added a commit that references this issue on Jul 15, 2026
  17. locked and limited conversation to collaborators on Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-System.SecurityenhancementProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is merged

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions