You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
DataContractSerialization is not linker friendly #36154
<!-- Too much private reflection. Do not bother with trimming -->
<ILLinkTrimAssembly>false</ILLinkTrimAssembly>
This setting only applies to running the linker during the dotnet/runtime build. It doesn't affect when a user's application uses this library and is trimmed.
If there is too much private reflection for this assembly to be trimmed, it isn't going to work well when an application using it is trimmed. We should ensure DataContractSerialization can be used safely by linked applications.
We should annotate the API with [RequiresUnreferencedCode] attributes then, so someone who is trimming their app gets warnings when they call this code.
Activity
HongGit commentedon Jun 25, 2020
The code is too intricate to be trimmed safely.
eerhardt commentedon Jun 26, 2020
We should annotate the API with
[RequiresUnreferencedCode]attributes then, so someone who is trimming their app gets warnings when they call this code.HongGit commentedon Jul 1, 2020
@eerhardt are you going to do this work? Can you please assign a milestone to this issue?
eerhardt commentedon Jul 1, 2020
I'm not sure who will actually do the work. But there will be an effort to get the libraries annotated in 6.0, so I moved it to there.
eerhardt commentedon Apr 29, 2021
This has been addressed with #50619 and #51200. Closing.