Repository navigation
[macOS-arm64] 55 System.DirectoryServices.Protocols.Tests fail on CoreCLR #49105
Description
See https://dev.azure.com/dnceng/public/_build/results?buildId=1021947
First few failures.
System.DirectoryServices.Protocols.Tests.PageResultRequestControlTests.Ctor_Cookie(cookie: null, expectedValue: [48, 6, 2, 2, 2, ...]) [FAIL]
System.DirectoryServices.Protocols.BerConversionException : An error occurred during the BER conversion.
Stack Trace:
/_/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/BerConverter.cs(209,0): at System.DirectoryServices.Protocols.BerConverter.Encode(String format, Object[] value)
/_/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/DirectoryControl.cs(599,0): at System.DirectoryServices.Protocols.PageResultRequestControl.GetValue()
/_/src/libraries/System.DirectoryServices.Protocols/tests/PageResultRequestControlTests.cs(72,0): at System.DirectoryServices.Protocols.Tests.PageResultRequestControlTests.Ctor_Cookie(Byte[] cookie, Byte[] expectedValue)
System.DirectoryServices.Protocols.Tests.SecurityDescriptorFlagControlTests.Ctor_Flags(masks: Group, expectedValue: [48, 3, 2, 1, 2]) [FAIL]
Assert.Equal() Failure
Expected: Byte[] [48, 3, 2, 1, 2]
Actual: Byte[] [48, 6, 2, 4, 112, ...]
Stack Trace:
/_/src/libraries/System.DirectoryServices.Protocols/tests/SecurityDescriptorFlagControlTests.cs(41,0): at System.DirectoryServices.Protocols.Tests.SecurityDescriptorFlagControlTests.Ctor_Flags(SecurityMasks masks, Byte[] expectedValue)
System.DirectoryServices.Protocols.Tests.ExtendedDNControlTests.Ctor_Default [FAIL]
Assert.Equal() Failure
Expected: Byte[] [48, 3, 2, 1, 0]
Actual: Byte[] [48, 6, 2, 4, 112, ...]
Stack Trace:
/_/src/libraries/System.DirectoryServices.Protocols/tests/ExtendedDNControlTests.cs(23,0): at System.DirectoryServices.Protocols.Tests.ExtendedDNControlTests.Ctor_Default()
System.DirectoryServices.Protocols.Tests.VlvRequestControlTests.Ctor_BeforeCount_AfterCount_ByteArrayTarget(beforeCount: 0, afterCount: 0, target: null, expectedValue: [48, 14, 2, 1, 0, ...]) [FAIL]
Assert.Equal() Failure
Expected: Byte[] [48, 14, 2, 1, 0, ...]
Actual: Byte[] [48, 30, 2, 4, 112, ...]
Stack Trace:
/_/src/libraries/System.DirectoryServices.Protocols/tests/VlvRequestControlTests.cs(102,0): at System.DirectoryServices.Protocols.Tests.VlvRequestControlTests.Ctor_BeforeCount_AfterCount_ByteArrayTarget(Int32 beforeCount, Int32 afterCount, Byte[] target, Byte[] expectedValue)
System.DirectoryServices.Protocols.Tests.BerConverterTests.Encode_Objects_ReturnsExpected(format: "tetie", values: [128, 0, 133, 2, 3], expected: [128, 1, 0, 133, 1, ...]) [FAIL]
Exception of type 'Xunit.Sdk.AssertActualExpectedException' was thrown.
Expected: 128, 1, 0, 133, 1, 2, 10, 1, 3
Actual: 1, 112, 0, 0, 116, 4, 112, 0, 0, 101, 1, 112, 0, 0, 116, 4, 112, 0, 0, 105, 10, 4, 112, 0, 0, 101
Stack Trace:
/_/src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs(370,0): at System.AssertExtensions.Equal[T](T[] expected, T[] actual)
/_/src/libraries/System.DirectoryServices.Protocols/tests/BerConverterTests.cs(49,0): at System.DirectoryServices.Protocols.Tests.BerConverterTests.Encode_Objects_ReturnsExpected(String format, Object[] values, Byte[] expected)/cc @sandreenko These look a bit like ABI issues.
Activity
12 remaining items
sandreenko commentedon Apr 29, 2021
It looks like it is passing on x64 Unix/OSX, but does not pass on arm64 Unix/OSX. I can't find the former pipelines that were running arm64 OSX so can't check there.
Because the failures are blocking innerloop I am going to revert the change and fix the issue locally.
sdmaclea commentedon Apr 29, 2021
@sandreenko The libraries tests are not enabled on PRs right now. They are only on rolling builds. I am not sure if they are inner or outer. If you want to trigger those runs manually, I can probably figure out where the pipeline is...
sandreenko commentedon Apr 29, 2021
Yes, I am searching for a pipeline that runs arm64 MacOS libraries tests, would be nice if you can point me to it.
sdmaclea commentedon Apr 29, 2021
The libraries innerloop test are run in the runtime rolling CI builds. Here https://dev.azure.com/dnceng/public/_build/results?buildId=1114297&view=results
The libraries outerloop tests are run here https://dev.azure.com/dnceng/public/_build?definitionId=678.
Unlike the runtime tests, for libraries the inner and outer loop sets are non overlapping. Outer is not a superset of inner (like it is for runtime tests)
sandreenko commentedon Apr 29, 2021
Does it include the test run? I see only Libraries Build jobs there.
sdmaclea commentedon Apr 29, 2021
The libraries tests can be run as part of the build job.
https://dev.azure.com/dnceng/public/_build/results?buildId=1113767&view=results
This one clearly ran some tests as part of the build. It had failures.
The osx one did too. It didn't have failures so I had to show passed tests in the tests tab to verify.
sandreenko commentedon Apr 29, 2021
I see, thanks Steve, looks like in some pipelines we have "Libraries Test Run" where we run libraries tests, like: https://dev.azure.com/dnceng/public/_build/results?buildId=1114559&view=logs&j=ba66422d-a35c-5bc8-b6c6-3a55f049cbee
and "Libraries Build" only build the tests as expected https://dev.azure.com/dnceng/public/_build/results?buildId=1114559&view=logs&j=914575e7-736f-5eab-a41f-513880ce642e
but in the others, we run them as part of "Libraries Build", like https://dev.azure.com/dnceng/public/_build/results?buildId=1113761&view=results
sandreenko commentedon Apr 30, 2021
notes for me:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46942
https://groups.google.com/g/x86-64-abi/c/E8O33onbnGQ?pli=1