Skip to content

CertificateSelection callback is not called when client use Unified framing #68310

Closed

Description

@wfurt

Some older TLS implementations can use Unified framing e.g. legacy SSL2 format with TLS 1.x body.
With 6.0, we fail to detect the client hello and therefore we fail to call the callback.
This is going to fail completely with 7.0 code base.

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Apr 21, 2022
  2. added this to the 7.0.0 milestone on Apr 21, 2022
  3. added and removed
    untriagedNew issue has not been triaged by the area owner
    on Apr 21, 2022
  4. karelz commented on Apr 21, 2022

    @karelz
    Member

    Triage: Used by YARP customer with older devices.

  5. wfurt commented on Apr 21, 2022

    @wfurt
    MemberAuthor

    Just to elaborate little bit more:

    image

    The example above is TLS 1.0 session. The first frame comes in as sslv2/Unified formatted hello and server respond with "normal" TLS 1.0 ServerHello. This generally prevents any TLS extensions but it would achieve TLS 1.0 security e.g. no real ssl2 involvement.

  6. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Apr 22, 2022
  7. self-assigned this
    on May 4, 2022
  8. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on May 4, 2022
  9. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on May 26, 2022
  10. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jun 8, 2022
  11. ghost locked as resolved and limited conversation to collaborators on Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions