Skip to content

PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration test failure #86013

Closed

Description

@jkotas
  Discovering: System.Resources.Extensions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Resources.Extensions.Tests (found 26 test cases)
  Starting:    System.Resources.Extensions.Tests (parallel test collections = on, max threads = 2)
    System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration(useEnumeratorEntry: False) [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs(531,0): at System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration(Boolean useEnumeratorEntry)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(59,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
  Finished:    System.Resources.Extensions.Tests

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=266915
Build error leg or test failing: System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration
Pull request: #85962

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration",
  "BuildRetry": true,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Report

Build Definition Step Name Console log Pull Request
270335 dotnet/runtime Send to Helix Log #86091
Build Definition Test Pull Request
284189 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #86674
282666 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #86567
282482 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration
276887 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #86151
276622 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #85965
274034 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #86252
272903 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #86210
270987 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #84384
270027 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #86074
269251 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #85843
268707 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #85317
266915 dotnet/runtime System.Resources.Extensions.Tests.PreserializedResourceWriterTests.TestResourceManagerIsSafeForConcurrentAccessAndEnumeration #85962

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
1 3 13

Activity

  1. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 9, 2023
  2. added this to the 8.0.0 milestone on May 16, 2023
  3. ghost removed
    untriagedNew issue has not been triaged by the area owner
    on May 16, 2023
  4. buyaa-n commented on May 16, 2023

    @buyaa-n
    Contributor

    Related to #75054 CC: @madelson the test still fails occasionally

  5. madelson commented on May 17, 2023

    @madelson
    Contributor

    @buyaa-n I assume we're hitting timeouts/contention? Do you think it would help to use TaskCreationOptions.LongRunning when creating the threads here?

    We could also increase the timeout even more than what it currently is.

  6. buyaa-n commented on May 23, 2023

    @buyaa-n
    Contributor

    I assume we're hitting timeouts/contention?

    Yes

    Do you think it would help to use TaskCreationOptions.LongRunning when creating the threads here?

    That was actually suggested previously and apparently you applied the suggestion only to ResourceManagerTests.cs

    .Select(_ => Task.Factory.StartNew(
    WaitForBarrierThenEnumerateResources,
    CancellationToken.None,
    TaskCreationOptions.LongRunning,
    TaskScheduler.Default))

    Please apply the suggestion to this test too, thanks!

  7. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on May 24, 2023
  8. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on May 24, 2023
  9. ghost locked as resolved and limited conversation to collaborators on Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Known Build ErrorUse this to report build issues in the .NET Helix tabarea-System.Resourcesblocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions