Repository navigation
Remove FindFirstFile, FindNextFile and FindClose from PAL - #110797
Merged
Merged
Conversation
Also remove the related tests
BruceForstall
approved these changes
Dec 18, 2024
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
LGTM
cc @jakobbotsch
This was referenced Dec 18, 2024
Member
|
Not really, still one more test using them. |
Member
corehost has pal abstraction for the searching functionality, but not shared with other components yet. |
| unsigned int codePage = CP_UTF8; | ||
| int sizeNeeded = MultiByteToWideChar(codePage, 0, str, -1, NULL, 0); | ||
| WCHAR* encodedStr = new WCHAR[sizeNeeded]; | ||
| MultiByteToWideChar(codePage, 0, str, -1, encodedStr, sizeNeeded); |
Member
There was a problem hiding this comment.
As follow-up, could we convert these two methods (ConvertMultiByteToWideChar and ConvertWideCharToMultiByte) to use the minipal as they're both UTF8-only? It would allow us to further reduce the usage of the CoreCLR PAL within superpmi.
jkoritzinsky
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes these functions from PAL. It also removes all the related PAL tests.
The superpmi was the last user of those functions, so I've modified it to use Unix APIs directly when building for Unix.