Repository navigation
Combine cast => negate => compare on ARM64 - #112944
Merged
Merged
Conversation
For example `a == -(sbyte)b`, ``` sxtb w0, w0 neg w0, w0 cmp w1, w0 ``` becomes ``` cmn w1, w0, SXTB ``` Contributes towards dotnet#68028
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
kunalspathak
approved these changes
Feb 28, 2025
kunalspathak
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Interestingly, there are no asmdiffs so seems this pattern is uncommon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example
a == -(sbyte)b,becomes
Contributes towards #68028