Repository navigation
[Android] Include static native libraries in CoreCLR Android runtime pack - #115610
Merged
kotlarmilos merged 2 commits intoMay 17, 2025
Merged
kotlarmilos merged 2 commits into
kotlarmilos merged 2 commits into
Conversation
kotlarmilos
requested review from
grendello and
jkoritzinsky
and removed request for
Copilot
May 15, 2025 13:35
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CoreCLR Android runtime pack to include required static native libraries and excludes Mono static libraries from sample app linking.
- Updated the Android build (ApkBuilder.cs) to add filtering for static Mono libraries.
- Modified multiple CMakeLists.txt files to install native static libraries to the sharedFramework destination on Android.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tasks/AndroidAppBuilder/ApkBuilder.cs | Adjusts logic to filter out Mono static libraries and ensures the native library list is correctly built. |
| src/native/libs/System.Security.Cryptography.Native.Android/CMakeLists.txt | Updates install target to include installation in sharedFramework for Android. |
| src/native/libs/System.Native/CMakeLists.txt | Similar update for System.Native-Static installation on Android. |
| src/native/libs/System.IO.Compression.Native/CMakeLists.txt | Adds install destination for System.IO.Compression.Native-Static in sharedFramework on Android. |
| src/native/libs/System.Globalization.Native/CMakeLists.txt | Adds install destination for System.Globalization.Native-Static in sharedFramework on Android. |
Contributor
|
Tagging subscribers to this area: @hoyosjs |
This was referenced May 15, 2025
jkoritzinsky
approved these changes
May 15, 2025
steveisok
self-requested a review
May 15, 2025 18:47
steveisok
approved these changes
May 15, 2025
steveisok
left a comment
Member
There was a problem hiding this comment.
Did you happen to run an official build and inspect the artifacts?
grendello
approved these changes
May 16, 2025
Member
Author
Yes, I ran the unified VMR build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the runtime build to ensure that required static native libraries are installed into the sharedFramework and are available in the final runtime pack:
Additionally, it excludes Mono static libraries from being linked into sample app.