Repository navigation
[mono][interp] Add missing intrinsic for Volatile.ReadBarrier/WriteBarrier - #124538
Merged
Merged
Conversation
…rrier For simplicity, this just adds full memory barriers. Previously, calling this code would lead to stack overflow due to recursively calling itself.
BrzVlad
requested review from
kotlarmilos,
steveisok and
vitek-karas
as code owners
February 18, 2026 08:07
Contributor
|
Tagging subscribers to this area: @vitek-karas, @BrzVlad, @kotlarmilos |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mono’s interpreter intrinsic handling to recognize System.Threading.Volatile.ReadBarrier and System.Threading.Volatile.WriteBarrier, preventing infinite recursion/stack overflow when these [Intrinsic] stub methods are executed under the interpreter.
Changes:
- Add interpreter intrinsic mapping for
Volatile.ReadBarrier()andVolatile.WriteBarrier(). - Implement the intrinsic by emitting an existing interpreter memory-barrier opcode.
kotlarmilos
approved these changes
Feb 18, 2026
5 tasks done
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…rrier (dotnet#124538) For simplicity, this just adds full memory barriers. Previously, calling this code would lead to stack overflow due to recursively calling itself.
Member
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For simplicity, this just adds full memory barriers. Previously, calling this code would lead to stack overflow due to recursively calling itself.