Repository navigation
[browser] Review concatenation logic in WebAssembly SDK - #127552
Merged
Merged
Conversation
Replace string concatenation of directory properties with proper MSBuild path functions: - +filename → $([MSBuild]::NormalizePath(...)) - +wwwroot → $([MSBuild]::NormalizeDirectory(...)) This ensures paths are correctly combined regardless of whether the directory properties have trailing separators. Fixes dotnet#103783 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WebAssembly Browser SDK targets to avoid fragile path concatenation and instead use MSBuild’s built-in path normalization helpers, making path construction resilient to whether input directory properties include trailing separators.
Changes:
- Replace
$(IntermediateOutputPath)$(_WasmBootConfigFileName)/$(IntermediateOutputPath)$(_WasmPublishBootConfigFileName)concatenations with$([MSBuild]::NormalizePath(...)). - Replace
$(PublishDir)wwwrootconcatenations with$([MSBuild]::NormalizeDirectory($(PublishDir), 'wwwroot'))for Static Web AssetsContentRoot.
ilonatommy
approved these changes
Apr 29, 2026
pavelsavara
approved these changes
Apr 29, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
radekdoulik
approved these changes
May 5, 2026
jakobbotsch
pushed a commit
to jakobbotsch/runtime
that referenced
this pull request
May 12, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was AI/Copilot-generated.
Replace string concatenation of directory properties with proper MSBuild path functions in
Microsoft.NET.Sdk.WebAssembly.Browser.targets:$(IntermediateOutputPath)$(_WasmBootConfigFileName)→$([MSBuild]::NormalizePath(...))$(PublishDir)wwwroot→$([MSBuild]::NormalizeDirectory($(PublishDir), 'wwwroot'))This ensures paths are correctly combined regardless of whether the directory properties have trailing separators.
Fixes #103783