Repository navigation
Remove some dead code from impAppendStmt and impStoreStruct - #128033
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs missed cleanup in CoreCLR JIT import logic by removing unreachable/dead code paths related to retbuf handling in impAppendStmt and impStoreStruct, without changing effective behavior.
Changes:
- Simplifies
impAppendStmtretbuf retrieval by removing an unreachable branch and asserting the existingHasRetBuffer()invariant. - Removes a dead local/conditional in
impStoreStructand unconditionally tags the inserted arg asWellKnownArg::RetBuffer(as it already effectively did).
jakobbotsch
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed cleanup from #105023