Repository navigation
Conversation
The test uses IpcTraceTest.RunAndValidateEventCounts to run 3 separate EventPipe sessions to capture JIT events and verify profiler dynamic optimization tier switching. Under GCStress, each session takes ~20 seconds because GC constantly suspends threads and slows down EventPipe event delivery. Three iterations exceeds the test timeout. There is also a SIGSEGV (exit code 139) on Linux ARM32 under gcstress0xc_disabler2r during the second EventPipe session setup. The test is already JitOptimizationSensitive and validates profiler behavior with optimization tiers -- it has no dependency on GCStress behavior. Mark it GCStressIncompatible to exclude it from GCStress runs. Fixes dotnet#118839 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5faa892-3c6f-4339-b47e-80f2d477e0a7
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Marks the DynamicOptimization profiler test project as incompatible with GC stress runs so the test infrastructure will skip executing it when DOTNET_GCStress is set (consistent with the existing GCStressIncompatible handling in src/tests/Common/CLRTest.Execute.*.targets).
Changes:
- Add
<GCStressIncompatible>true</GCStressIncompatible>toDynamicOptimization.csproj. - Document the reason for the incompatibility (EventPipe session slowness under GC stress).
steveisok
approved these changes
Aug 14, 2026
mdh1418
deleted the
mdh1418/fix-118839-dynamicoptimization-gcstress-timeout
branch
August 14, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118839