Repository navigation
[System.Net.Http] Fix Android certificate validation tests - #135786
Closed
tannergooding wants to merge 2 commits into
Closed
tannergooding wants to merge 2 commits into
tannergooding wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
rzikm
approved these changes
Oct 15, 2026
Member
|
/ba-g Only known test errors |
Member
|
Should we disable the run on Android if the right capability is not there? I'm not sure if putting all the conditionals to the test brings value. |
rzikm
requested changes
Oct 16, 2026
rzikm
left a comment
Member
There was a problem hiding this comment.
On a second thought, I think we should make the change for all platforms to use the independent root + (possibly expired) leaf cert on the server, to reduce test setup complexity.
Use distinct root and leaf certificates for validation tests. Keep the .NET Framework self-signed fallback because the legacy loopback server cannot present issuer chains. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
@tannergooding There are merge conflicts, I think the test failures were fixed by #135975 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android does not support an empty
CustomRootTruststore, and trusting an expired self-signed certificate as its own root can bypass expiry validation. This caused the bad-certificate tests to fail on Android.Use platform trust when no custom root is specified. For expired-certificate cases, use an expired server leaf signed by a separate, valid root; keep the existing WinHTTP-specific certificate path unchanged.
This resolves #135782
Note
This PR description was prepared with GitHub Copilot.