Repository navigation
[manual] Merge release/8.0-staging into release/8.0 to unblock MSRC internal-to-public builds - #135931
Merged
Conversation
Fixes dotnet#135879 main PR dotnet#135749 # Description <!-- Give a brief summary of the issue and how the pull request is fixing it. --> Updates the public release/8.0 servicing branch to use the publicly available MsQuic 2.5.12 package. This completes the private-to-public security servicing handoff so internal-to-public merges do not retain the private `2.5.11-ci.159417053` identifier that public CI cannot restore. # Customer Impact <!-- What is the impact to customers of not taking this fix? --> Public release/8.0 builds fail restore with NU1603 because the private MsQuic servicing package is unavailable to public CI, blocking clean servicing builds. # Regression <!-- Is this fixing a problem that was introduced in the most recent release, ie., fixing a regression? --> This is not a product-code regression. The failure occurs during the post-disclosure dependency handoff from private MSRC bits to the corresponding public package. # Testing <!-- What kind of testing has been done with the fix. --> Passed: ```console .\dotnet.cmd restore .\src\libraries\System.Net.Quic\src\System.Net.Quic.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 --no-cache ``` The restore resolved MsQuic 2.5.12 without NU1603. # Risk <!-- Please assess the risk of taking this fix. Provide details backing up your assessment. --> Low. This is a one-line patch-version dependency update to the public servicing package, with no managed-code changes. Full functional testing is delegated to CI. # Package authoring signed off? IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](../../docs/project/library-servicing.md) and gotten it explicitly reviewed. No package project or package metadata is changed; this only updates the pinned native dependency version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b0b9c360-7d5d-4fdc-bede-48036e9dd9b7
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
mrek-msft
approved these changes
Oct 16, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Member
Author
|
/ba-g DeadLetter and unrelated flakiness (Helix client cleanup failure) |
ViveliDuCh
added a commit
that referenced
this pull request
Oct 16, 2026
…nternal-to-public builds (#135931) #135883 The current internal-to-public merge against `release/8.0` is failing across multiple Windows build legs because of the same warning-as-error: src/libraries/System.Net.Quic/src/System.Net.Quic.csproj(0,0): error NU1603: Warning As Error: System.Net.Quic depends on Microsoft.Native.Quic.MsQuic.Schannel (>= 2.5.11-ci.159417053) but Microsoft.Native.Quic.MsQuic.Schannel 2.5.11-ci.159417053 was not found. An approximate best match of Microsoft.Native.Quic.MsQuic.Schannel 2.5.11-rc was resolved. `2.5.11-ci.159417053` is the private MsQuic package used internally during coordinated MSRC servicing, so it is intentionally unavailable to public builds. Now that the corresponding public servicing package is available as `2.5.12`, [#135883](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fruntime%2Fpull%2F135884&data=05%7C02%7Cvivianad%40microsoft.com%7C98d3318ead20454faf1908df2aee27ca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C639276874519544099%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=JIfQXtmjD%2FWBgKaNh5ZZXLClxdNNZQM0b5Z60o2MNjM%3D&reserved=0) updates `release/8.0-staging` to that version. A targeted `System.Net.Quic` restore passed locally without `NU1603`. Once this change reaches `release/8.0` and the internal-to-public merge is refreshed, public CI should be able to restore the dependency normally. (cherry picked from commit b60797b)
ViveliDuCh
added a commit
that referenced
this pull request
Oct 16, 2026
…nternal-to-public builds (#135931) #135883 The current internal-to-public merge against `release/8.0` is failing across multiple Windows build legs because of the same warning-as-error: src/libraries/System.Net.Quic/src/System.Net.Quic.csproj(0,0): error NU1603: Warning As Error: System.Net.Quic depends on Microsoft.Native.Quic.MsQuic.Schannel (>= 2.5.11-ci.159417053) but Microsoft.Native.Quic.MsQuic.Schannel 2.5.11-ci.159417053 was not found. An approximate best match of Microsoft.Native.Quic.MsQuic.Schannel 2.5.11-rc was resolved. `2.5.11-ci.159417053` is the private MsQuic package used internally during coordinated MSRC servicing, so it is intentionally unavailable to public builds. Now that the corresponding public servicing package is available as `2.5.12`, [#135883](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fruntime%2Fpull%2F135884&data=05%7C02%7Cvivianad%40microsoft.com%7C98d3318ead20454faf1908df2aee27ca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C639276874519544099%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=JIfQXtmjD%2FWBgKaNh5ZZXLClxdNNZQM0b5Z60o2MNjM%3D&reserved=0) updates `release/8.0-staging` to that version. A targeted `System.Net.Quic` restore passed locally without `NU1603`. Once this change reaches `release/8.0` and the internal-to-public merge is refreshed, public CI should be able to restore the dependency normally. (cherry picked from commit b60797b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#135883
The current internal-to-public merge against
release/8.0is failing across multiple Windows build legs because of the same warning-as-error:src/libraries/System.Net.Quic/src/System.Net.Quic.csproj(0,0): error NU1603: Warning As Error: System.Net.Quic depends on Microsoft.Native.Quic.MsQuic.Schannel (>= 2.5.11-ci.159417053) but Microsoft.Native.Quic.MsQuic.Schannel 2.5.11-ci.159417053 was not found. An approximate best match of Microsoft.Native.Quic.MsQuic.Schannel 2.5.11-rc was resolved.
2.5.11-ci.159417053is the private MsQuic package used internally during coordinated MSRC servicing, so it is intentionally unavailable to public builds. Now that the corresponding public servicing package is available as2.5.12, dotnet/runtime#135883 updatesrelease/8.0-stagingto that version. A targetedSystem.Net.Quicrestore passed locally withoutNU1603. Once this change reachesrelease/8.0and the internal-to-public merge is refreshed, public CI should be able to restore the dependency normally.