Repository navigation
JIT: exclude arm64 writeback accesses from load/store peepholes #137528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AndyAyersMS
merged 1 commit into
dotnet:main
from
AndyAyersMS:fix-135522-arm64-post-index
Nov 18, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
| using Xunit; | ||
|
|
||
| public class Runtime_135522 | ||
| { | ||
| [StructLayout(LayoutKind.Sequential, Pack = 1)] | ||
| private struct Packed | ||
| { | ||
| public long Value; | ||
| public byte Padding; | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1L, 3L)] | ||
| [InlineData(long.MinValue, long.MaxValue)] | ||
| public static void LoadAfterPostIndex(long first, long second) | ||
| { | ||
| Packed[] values = new Packed[4]; | ||
| values[0].Value = first; | ||
| values[2].Value = second; | ||
| Assert.Equal(first ^ second, LoadForward(values)); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1L, 3L)] | ||
| [InlineData(long.MinValue, long.MaxValue)] | ||
| public static void LoadPairAfterPostIndex(long first, long second) | ||
| { | ||
| long[] values = { second, 11, 22, first, 33, 44, 55, 66 }; | ||
| Assert.Equal(first ^ second, LoadBackward(values.AsSpan(3))); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(1L, 3L)] | ||
| [InlineData(long.MinValue, long.MaxValue)] | ||
| public static void StorePairAfterPostIndex(long first, long second) | ||
| { | ||
| long[] values = { second, 11, 22, first, 33, 44, 55, 66 }; | ||
| StoreBackward(values.AsSpan(3), second, first); | ||
| Assert.Equal(new long[] { first, 11, 22, second, 33, 44, 55, 66 }, values); | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static long LoadForward(Span<Packed> values) | ||
| { | ||
| if (values.Length < 4) | ||
| { | ||
| return 0; | ||
| } | ||
|
|
||
| long first = values[0].Value; | ||
| values = values.Slice(1); | ||
| long second = values[1].Value; | ||
| return first ^ second; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static long LoadBackward(Span<long> values) | ||
| { | ||
| if (values.Length < 4) | ||
| { | ||
| return 0; | ||
| } | ||
|
|
||
| long first = values[0]; | ||
| values = MemoryMarshal.CreateSpan(ref Unsafe.Subtract(ref MemoryMarshal.GetReference(values), 1), values.Length); | ||
| long second = Unsafe.Subtract(ref MemoryMarshal.GetReference(values), 2); | ||
| return first ^ second; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] | ||
| private static void StoreBackward(Span<long> values, long first, long second) | ||
| { | ||
| if (values.Length < 4) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| values[0] = first; | ||
| values = MemoryMarshal.CreateSpan(ref Unsafe.Subtract(ref MemoryMarshal.GetReference(values), 1), values.Length); | ||
| Unsafe.Subtract(ref MemoryMarshal.GetReference(values), 2) = second; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.