Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,10 @@ internal void LocalClear()
{
_headIndex = _tailIndex = StartIndex;
_addTakeCount = _stealCount = 0;
Array.Clear(_array);
if (RuntimeHelpers.IsReferenceOrContainsReferences<T>())
{
Array.Clear(_array);
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,28 @@ select Task.Factory.StartNew(() =>
}
}

[Fact]
public static void Clear_AfterRemoval_DoesNotExposeOldItems()
{
var bag = new ConcurrentBag<int>(new[] { 1, 2, 3 });
Assert.True(bag.TryTake(out _));

bag.Clear();
Assert.Empty(bag);
Assert.False(bag.TryPeek(out _));
Assert.False(bag.TryTake(out _));

bag.Add(4);
bag.Add(5);
Assert.Equal(new[] { 4, 5 }, bag.OrderBy(item => item));
var remaining = new HashSet<int> { 4, 5 };
while (bag.TryTake(out int item))
{
Assert.True(remaining.Remove(item));
}
Assert.Empty(remaining);
}

[Fact]
public static void Clear_DuringEnumeration_DoesntAffectEnumeration()
{
Expand Down
Loading