Repository navigation
Cleanup NETCOREAPP ifdef usage in System.Runtime.Tests - #22224
Merged
Merged
Conversation
Member
Author
|
I will fix this up to be compatible with platforms that have PNSE reflection.emit. |
safern
approved these changes
Feb 1, 2020
Member
Author
|
Test failure due to #2209 |
Member
|
I see another failure also in some System.Net.Tests |
Member
Author
|
Yeah, there is a assorted variety of crashes on both CoreCLR and Mono. I do not see how this PR could have caused it. It is only updating System.Runtime tests... I think a bad PR got merged sometime today. I am trying to find it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21827