Skip to content

Finish the other part of the GCTotalPhysicalMemory config implementation - #36152

Merged
jkotas merged 3 commits into
dotnet:masterfrom
jkotas:phymem_config
May 9, 2020
Merged

jkotas merged 3 commits into
dotnet:masterfrom
jkotas:phymem_config

Conversation

@jkotas

@jkotas jkotas commented May 8, 2020

Copy link
Copy Markdown
Member

No description provided.

Maoni0 and others added 3 commits May 5, 2020 22:32
The total physical memory specified by the GCTotalPhysicalMemory config
needs to communicated over to the VM side for memory load calculation.
Otherwise inside GC we are using the correct physical memory specified,
but when we ask for the memory load it's still based on the total available
memory.
@ghost

ghost commented May 8, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @Maoni0
Notify danmosemsft if you want to be subscribed.

@Maoni0 Maoni0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this too; thanks @jkotas! since you feel strongly enough to write up an impl, let's go with this.

@Maoni0 Maoni0 changed the title (Alternative) Finish the other part of the GCTotalPhysicalMemory config implementation Finish the other part of the GCTotalPhysicalMemory config implementation May 9, 2020
@jkotas
jkotas merged commit caf6923 into dotnet:master May 9, 2020
@jkotas
jkotas deleted the phymem_config branch May 16, 2020 17:11
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants