Skip to content

[release/5.0] Remove System.Net.Connections and related features (#41648) - #41725

Merged
geoffkizer merged 1 commit into
dotnet:release/5.0from
geoffkizer:port41648to50
Sep 2, 2020
Merged

geoffkizer merged 1 commit into
dotnet:release/5.0from
geoffkizer:port41648to50

Conversation

@geoffkizer

@geoffkizer geoffkizer commented Sep 2, 2020 •

Copy link
Copy Markdown
Contributor

Backport to 5.0. Approved in tactics this morning.

Original PR: #41648

* remove System.Net.Connections and related features

* cleanup csproj changes

* Update src/libraries/pkg/baseline/packageIndex.json

Co-authored-by: Cory Nelson <phrosty@gmail.com>

* Update src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs

Co-authored-by: Cory Nelson <phrosty@gmail.com>

Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
Co-authored-by: Cory Nelson <phrosty@gmail.com>
@Dotnet-GitSync-Bot

Copy link
Copy Markdown
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@Dotnet-GitSync-Bot

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@geoffkizer

Copy link
Copy Markdown
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@geoffkizer geoffkizer added this to the 5.0.0 rc1 milestone Sep 2, 2020
@scalablecory scalablecory changed the title Remove System.Net.Connections and related features (#41648) [release/5.0] Remove System.Net.Connections and related features (#41648) Sep 2, 2020
@geoffkizer
geoffkizer merged commit d2e8221 into dotnet:release/5.0 Sep 2, 2020
@karelz karelz modified the milestones: 5.0.0 rc1, 5.0.0 Sep 9, 2020
@geoffkizer
geoffkizer deleted the port41648to50 branch November 7, 2020 23:40
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants