Skip to content

delete dead System.Net.Connections code - #42099

Merged
jkotas merged 1 commit into
dotnet:release/5.0-rc2from
geoffkizer:deleteconnections
Sep 13, 2020
Merged

jkotas merged 1 commit into
dotnet:release/5.0-rc2from
geoffkizer:deleteconnections

Conversation

@geoffkizer

Copy link
Copy Markdown
Contributor

This code is no longer used. Delete it from the 5.0 release to prevent confusion or accidents.

@ghost

ghost commented Sep 11, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley

Copy link
Copy Markdown
Contributor

@ericstj can you see anything else that might need updating -- eg., where it would be packaged in (but we believe it currently isn't)?

@geoffkizer geoffkizer added this to the 5.0.0 milestone Sep 11, 2020

@antonfirsov antonfirsov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericstj

ericstj commented Sep 12, 2020

Copy link
Copy Markdown
Member

where it would be packaged in (but we believe it currently isn't)?

We didn't package this before. It was only shipping inside the shared framework and #41648 removed that.

@jkotas
jkotas merged commit 54dfce7 into dotnet:release/5.0-rc2 Sep 13, 2020
@danmoseley

Copy link
Copy Markdown
Contributor

@geoffkizer / @karelz did we get tactics permission for this? If not it's probably not worth raising now. Arguably it's part of the original change.

@geoffkizer

Copy link
Copy Markdown
Contributor Author

Not that I'm aware of.

@jkotas

jkotas commented Sep 14, 2020

Copy link
Copy Markdown
Member

I am sorry - I have note realized that this PR was against the release branch. It did not have the release tag in the title.

@danmoseley

Copy link
Copy Markdown
Contributor

It's fine @jkotas no harm done 😃

@geoffkizer
geoffkizer deleted the deleteconnections branch November 7, 2020 23:38
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants