Repository navigation
Fill out hardware intrinsics linker substitutions for unsupported platforms - #44156
Conversation
tannergooding
left a comment
There was a problem hiding this comment.
LGTM.
If we get a doc up on adding new HWIntrinsics, we should ensure that updating this file is included as part of the process.
|
Tagging subscribers to this area: @tannergooding, @jeffhandley |
| @@ -9,6 +9,9 @@ | |||
| <type fullname="System.Runtime.Intrinsics.Arm.Aes"> | |||
There was a problem hiding this comment.
I think it's worth splitting this up to to arm and arm64 files so we can disable arm64 intrinsics on arm builds.
There was a problem hiding this comment.
We don't support intrinsics on arm32 at all at this point. Check out the project file, we only support arm intrinsics on arm64:
We can split the file in the future when arm32 support is understood.
There was a problem hiding this comment.
ok, will split that once we support them
Added the recently added arm intrinsics classes:
DpandRdmto the linker subsitutions.I also ensured all the 64-bit nested classes are substituted as well, even if they don't have any methods.
Fix #44146