Repository navigation
[Release/5.0] Port [RyuJIT] Propagate gtFlags in Vector.Create to .NET 5.0 - #44979
Merged
Merged
Conversation
…T 5.0 PR in master: dotnet#43578 Propagate GTF_CALL if needed in GT_LIST. Use gtNewListNode. Ignore test for Mono
Member
Author
|
cc @dotnet/jit-contrib @tannergooding |
EgorBo
reviewed
Nov 20, 2020
| <ExcludeList Include="$(XunitTestBinBase)/baseservices/TieredCompilation/BasicTestWithMcj/*"> | ||
| <Issue>Tests features specific to coreclr</Issue> | ||
| </ExcludeList> | ||
| <ExcludeList Include="$(XunitTestBinBase)/Loader/CollectibleAssemblies/ByRefLocals/**"> |
Member
There was a problem hiding this comment.
A small note for reviewers: this change disables these new tests for Mono since there is a small issue on Mono with Vector256 but it doesn't affect .NET5 anyhow since the only Mono product we ship is Mono-interpreter for WebAssembly where SIMD stuff is not supported yet.
jeffschwMSFT
approved these changes
Nov 20, 2020
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a cr and then we can consider this for 5.0.1
Member
Author
|
ping @dotnet/jit-contrib would like to get this into 5.0.1 |
tannergooding
approved these changes
Nov 20, 2020
Member
Author
|
Think this ended up in 5.0.1 but unfortunately I set the milestone to 5.0.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43578
Customer Impact
Customer reported silent bad codegen when using hardware intrinsics (see #43569, #44704).
Testing
Missing test case. Checked builds were able to see the problem so this is just a case we never tested for.
Regression?
Yes; worked in 3.1.
Risk
Low, fix is very small and easy to understand