Skip to content

[release/5.0] Capture AVX context when redirecting threads for suspension - #47447

Merged
Anipik merged 2 commits into
dotnet:release/5.0from
VSadov:avx50
Feb 10, 2021
Merged

Anipik merged 2 commits into
dotnet:release/5.0from
VSadov:avx50

Conversation

@VSadov

@VSadov VSadov commented Jan 26, 2021 •

Copy link
Copy Markdown
Member

Re: #38974, #47016

These are the same changes as in #47212

Customer Impact

Once we move to the new toolset, managed code that employs AVX register set directly or indirectly (as in Span<byte> helpers) may occasionally observe incorrect computation results.

Testing

The fix was tested and merged in master. This is a port of the fix.

Risk

Master branch had this fix for some time now. Based on that the risk is low.

@ghost

ghost commented Jan 26, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@VSadov
VSadov requested a review from mangod9 January 26, 2021 02:46
@VSadov

VSadov commented Jan 26, 2021 •

Copy link
Copy Markdown
Member Author

I had to port this by hand since files have been moved and there was enough code changes to prevent automated porting or cherry-picking.
Otherwise it was a straightforward port. We did not have any real changes affecting how we work with OS context prior to this fix.

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Feb 1, 2021
@jeffschwMSFT jeffschwMSFT added this to the 5.0.x milestone Feb 1, 2021
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 2, 2021
@leecow leecow modified the milestones: 5.0.x, 5.0.4 Feb 2, 2021
@Anipik
Anipik merged commit 3fe7fe5 into dotnet:release/5.0 Feb 10, 2021
@VSadov
VSadov deleted the avx50 branch February 10, 2021 16:33
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants