Repository navigation
[wasm] Use '/' directory separator in .blat - #52066
Merged
radekdoulik merged 2 commits intoMay 3, 2021
Merged
Conversation
Fixes: dotnet#52007 We were using host system `PathSeparator`s, which lead to problems when building the app on windows
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes: #52007 We were using host system This change makes the
|
tqiu8
approved these changes
Apr 30, 2021
tqiu8
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Paths causing problems again on windows.
lewing
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52007
We were using host system
PathSeparators, which lead to problems whenbuilding the app on windows.
This change makes the
System.Runtimelibrary tests pass on windows.