Repository navigation
minor optimization: move creation of X509 Subject Summary into catch block on MacOS. - #54774
Merged
Merged
Conversation
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsCurrently we are making a call to Interop.AppleCrypto.X509GetSubjectSummary on each call to EnsureCertData.
|
Member
Author
|
cc: @stephentoub |
stephentoub
approved these changes
Jun 26, 2021
stephentoub
left a comment
Member
There was a problem hiding this comment.
Per #54613 (review). Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are making a call to Interop.AppleCrypto.X509GetSubjectSummary on each call to EnsureCertData.
However, this is needed only when something goes wrong, for a better error message. Thus, moving the call into the catch block.