Skip to content

[mono] Remove some of the restrictions on constrained calls from - #59182

Merged
vargaz merged 2 commits into
dotnet:mainfrom
vargaz:gsharedvt-constrained
Sep 17, 2021
Merged

vargaz merged 2 commits into
dotnet:mainfrom
vargaz:gsharedvt-constrained

Conversation

@vargaz

@vargaz vargaz commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

gsharedvt methods.

Fixes #58204.

@ghost

ghost commented Sep 15, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@vargaz
vargaz force-pushed the gsharedvt-constrained branch from 0f934e8 to ecce350 Compare September 16, 2021 10:56
lambdageek
lambdageek previously approved these changes Sep 17, 2021
@lambdageek

Copy link
Copy Markdown
Member

@vargaz Could you also remove the [ActiveIssue] from the tests in #58276

@lambdageek
lambdageek dismissed their stale review September 17, 2021 02:56

let's run again with the libraries tests re-enabled

@vargaz

vargaz commented Sep 17, 2021

Copy link
Copy Markdown
Contributor Author

Reenabled, is CI actually testing these configurations ?

@lambdageek

Copy link
Copy Markdown
Member

Reenabled, is CI actually testing these configurations ?

Think so. @akoeplinger are they disabled somewhere else for another reason?

@lewing

lewing commented Sep 17, 2021

Copy link
Copy Markdown
Member

they are disabled in src/libraries/tests.proj

@vargaz
vargaz merged commit 23a8a62 into dotnet:main Sep 17, 2021
@vargaz
vargaz deleted the gsharedvt-constrained branch September 17, 2021 19:29
@srxqds

srxqds commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

I am sorry to ask again for backporting to 6.0? because the 6.0 is a LTS release, hope bug fixes can be merged more and more.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@akoeplinger

Copy link
Copy Markdown
Member

To close the loop in this, we decided to hold off backporting this to 6.0 for now: #58204 (comment)

If you see an issue in a real project (not just constructed tests) then please file a new issue and we'll reconsider.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attempting to JIT compile method in System.Text.Json tests on iOS devices

5 participants