Skip to content

Sod pre command fix #60413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 11 commits into from
Oct 14, 2021
Merged

Sod pre command fix #60413

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cbc3444
Comment out unwanted pipeline steps for testing.
LoopedBard3 Oct 8, 2021
6d2ce16
Try out the different quote options to solve SOD issue.
LoopedBard3 Oct 8, 2021
2113896
Attempt 2 at getting SOD for blazor to take in multiple msbuild prope…
LoopedBard3 Oct 12, 2021
60da803
Final attempt, changed the semi-colons back to the url colon value.
LoopedBard3 Oct 12, 2021
ded0e93
Final Final fix attempt.
LoopedBard3 Oct 13, 2021
ed9fc77
Revert all attempts at different quote setups. Going to add logging t…
LoopedBard3 Oct 13, 2021
a16221d
Setup perf-setup to pull from my testing perf branch.
LoopedBard3 Oct 13, 2021
6e2997a
Figured out that two semicolons escapes to one, so trying that out to…
LoopedBard3 Oct 13, 2021
ea51fda
Need to test when the split is actually a semi-colon.
LoopedBard3 Oct 13, 2021
b03f966
Changed the perf-setup file to act like the original, good to merge.
LoopedBard3 Oct 14, 2021
26c8d42
Nearly missed the perf.yml file, updated the perf.yml to match it's t…
LoopedBard3 Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/testing/performance/blazor_perf.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
<HelixWorkItem Include="SOD - Minimum Blazor Template - Publish">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<!-- Specifying both linker dump msbuild properties in case linker version is not updated -->
<PreCommands>cd $(BlazorMinDirectory);$(Python) pre.py publish --msbuild "/p:_TrimmerDumpDependencies=true%3B/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;</PreCommands>
<PreCommands>cd $(BlazorMinDirectory);$(Python) pre.py publish --msbuild "/p:_TrimmerDumpDependencies=true;;/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;</PreCommands>
<Command>$(Python) test.py sod --scenario-name &quot;%(Identity)&quot;</Command>
</HelixWorkItem>
<HelixWorkItem Include="SOD - Minimum Blazor Template - Publish - AOT">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<!-- Specifying both linker dump msbuild properties in case linker version is not updated -->
<PreCommands>cd $(BlazorMinAOTDirectory);$(Python) pre.py publish --msbuild "/p:_TrimmerDumpDependencies=true%3B/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;</PreCommands>
<PreCommands>cd $(BlazorMinAOTDirectory);$(Python) pre.py publish --msbuild "/p:_TrimmerDumpDependencies=true;;/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;</PreCommands>
<Command>$(Python) test.py sod --scenario-name &quot;%(Identity)&quot;</Command>
</HelixWorkItem>
<HelixWorkItem Include="SOD - New Blazor Template - Publish">
Expand All @@ -56,7 +56,7 @@
</HelixWorkItem>
<HelixWorkItem Include="SOD - New Blazor Template - Publish - AOT">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<PreCommands>cd $(BlazorAOTDirectory);$(Python) pre.py publish --msbuild "/p:_TrimmerDumpDependencies=true%3B/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=%27&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;%27 --binlog %27./traces/blazor_publish.binlog%27</PreCommands>
<PreCommands>cd $(BlazorAOTDirectory);$(Python) pre.py publish --msbuild "/p:_TrimmerDumpDependencies=true;;/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=%27&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;%27 --binlog %27./traces/blazor_publish.binlog%27</PreCommands>
<Command>$(Python) test.py sod --scenario-name &quot;%(Identity)&quot;</Command>
<PostCommands>$(Python) post.py</PostCommands>
</HelixWorkItem>
Expand All @@ -70,7 +70,7 @@
<HelixWorkItem Include="SOD - Pizza App - Publish - AOT">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<!-- Specifying both linker dump msbuild properties in case linker version is not updated -->
<PreCommands>cd $(BlazorPizzaAOTDirectory);$(Python) pre.py publish -f $(PerflabTargetFrameworks) --msbuild "/p:_TrimmerDumpDependencies=true%3B/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=%27&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;%27 --binlog %27./traces/blazor_publish.binlog%27</PreCommands>
<PreCommands>cd $(BlazorPizzaAOTDirectory);$(Python) pre.py publish -f $(PerflabTargetFrameworks) --msbuild "/p:_TrimmerDumpDependencies=true;;/p:_MonoRuntimeComponentManifestJsonFilePath=$(WASMRuntimeConfigPath)" --msbuild-static AdditionalMonoLinkerOptions=%27&quot;%24(AdditionalMonoLinkerOptions) --dump-dependencies&quot;%27 --binlog %27./traces/blazor_publish.binlog%27</PreCommands>
<Command>$(Python) test.py sod --scenario-name &quot;%(Identity)&quot; --dirs $(PizzaAppPubLocation)</Command>
<PostCommands>$(Python) post.py</PostCommands>
<Timeout>1:00</Timeout>
Expand Down