Repository navigation
#71252 disable Atan2PiTest on Android x86 - #71382
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| } | ||
|
|
||
| [Theory] | ||
| [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotAndroid), nameof(PlatformDetection.IsNotX86Process))] // disabled on Android x86, see https://github.com/dotnet/runtime/issues/71252 |
There was a problem hiding this comment.
Won't this disable the test on all x86, not just for Android?
There was a problem hiding this comment.
From my understanding it works like PlatformDetection.IsNotAndroid && PlatformDetection.IsNotX86Process
There was a problem hiding this comment.
Right, so if it is x86, it fails the right clause, and that whole expression is false.
There was a problem hiding this comment.
I see , I will add new property in PlatformDetection then checking IsNotAndroid || (IsAndroid && IsNotX86Process)
There was a problem hiding this comment.
then checking IsNotAndroid || (IsAndroid && IsNotX86Process)
You just want !(IsAndroid && Isx86)
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsDisable Atan2PiTest on Android x86 #71252
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks. There's a good chance we'll be able to reenable those tests once #65723 lands. |
Disable Atan2PiTest on Android x86 #71252