Repository navigation
AcceptAsync with existing Socket support on Unix, Review Changes - #74645
Merged
liveans merged 2 commits intoSep 20, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsReview changes PR for #73499.
|
Contributor
Author
@stephentoub Looks like we don't have it. Dispose method has a condition like this: if (handle is not null) I can add a test for this behavior if you want to. |
stephentoub
reviewed
Sep 6, 2022
Contributor
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Sep 19, 2022
Contributor
Author
|
CI failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review changes PR for #73499.