Repository navigation
JIT: Fix purity of CORINFO_HELP_GETREFANY on win-x64 - #80292
Merged
Merged
Conversation
We mark this helper as pure, but on win-x64 the struct argument becomes an implicit byref and the JIT does not support purity through the "load".
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsWe mark this helper as pure, but on win-x64 the struct argument becomes an implicit byref and the JIT does not support purity through the "load". Alternative fix could be to teach Context: #79346 (comment)
|
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
10 tasks done
AndyAyersMS
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We mark this helper as pure, but on win-x64 the struct argument becomes an implicit byref and the JIT does not support purity through the "load".
Alternative fix could be to teach
fgValueNumberHelperCallFuncto handle implicit byrefs by creating a unique VN for them.Context: #79346 (comment)