Repository navigation
Emit compiler generated files in Com Generator test project - #85837
Closed
jtschuster wants to merge 1 commit into
Closed
jtschuster wants to merge 1 commit into
jtschuster wants to merge 1 commit into
Conversation
jkoritzinsky
reviewed
May 5, 2023
Comment on lines
+11
to
+12
| <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | ||
| <CompilerGeneratedFilesOutputPath>$(MSBuildThisFileDirectory)Generated</CompilerGeneratedFilesOutputPath> |
Member
There was a problem hiding this comment.
Can we have a comment here to clean this up once we finish making large changes to the generated code?
jkoritzinsky
approved these changes
May 5, 2023
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
Not the biggest fan of this, but it does make seeing the diffs easier as we make large changes to how we generate the code. As long as we remove this before we ship, I can be okay with it.
Member
Author
|
Decided we won't keep it around and there doesn't seem to be as much value in doing it for one diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to separate out the change to emit compiler generated files from #85117 to make the difference in behavior clearer.
The only real changes are in the .csproj, the rest is autogenerated.