Repository navigation
Merge ServicePoint assembly into Requests - #94510
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsPreparation for
|
…vicePoint.csproj Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
|
/azp list |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
left a comment
There was a problem hiding this comment.
Please make sure that there aren't any any other hits of "System.Net.ServicePoint", i.e. in tests.proj.
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wfurt
left a comment
There was a problem hiding this comment.
LGTM....but I'm not the expert. I would assume issues would surface via API compat or test failures.
|
Changes look good and APICompat ran successfully. Ready to go. |
|
CI Failures unrelated |
Preparation for
HttpWebRequest,ServicePoint, andServicePointManager's missing parts implementation.