Skip to content

Merge ServicePoint assembly into Requests - #94510

Merged
liveans merged 9 commits into
dotnet:mainfrom
liveans:merge-servicepoint-assembly-into-requests
Nov 9, 2023
Merged

liveans merged 9 commits into
dotnet:mainfrom
liveans:merge-servicepoint-assembly-into-requests

Conversation

@liveans

@liveans liveans commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Preparation for HttpWebRequest, ServicePoint, and ServicePointManager's missing parts implementation.

@ghost

ghost commented Nov 8, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned liveans Nov 8, 2023
@ghost

ghost commented Nov 8, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Preparation for HttpWebRequest, ServicePoint, and ServicePointManager's missing parts implementation.

Author: liveans
Assignees: -
Labels:

area-System.Net, new-api-needs-documentation

Milestone: -

…vicePoint.csproj

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@liveans

liveans commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@liveans

liveans commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans
liveans marked this pull request as ready for review November 8, 2023 13:46
@liveans
liveans requested a review from a team November 8, 2023 13:47

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that there aren't any any other hits of "System.Net.ServicePoint", i.e. in tests.proj.

@liveans

liveans commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans

liveans commented Nov 8, 2023

Copy link
Copy Markdown
Contributor Author

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM....but I'm not the expert. I would assume issues would surface via API compat or test failures.

@ViktorHofer

Copy link
Copy Markdown
Member

Changes look good and APICompat ran successfully. Ready to go.

@liveans

liveans commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

CI Failures unrelated

@liveans
liveans merged commit 0af8b25 into dotnet:main Nov 9, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2023
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants