Skip to content

Code coverage for Server-side OCSP stapling - #97099

Merged
rzikm merged 5 commits into
dotnet:mainfrom
rzikm:96791-coverage-for-server-OCSP-stapling
Jan 31, 2024
Merged

Code coverage for Server-side OCSP stapling#97099
rzikm merged 5 commits into
dotnet:mainfrom
rzikm:96791-coverage-for-server-OCSP-stapling

Conversation

@rzikm

@rzikm rzikm commented Jan 17, 2024

Copy link
Copy Markdown
Member

Adds tests for getting OCSP staple to send in TLS handshake, including testing staple refresh and correct handling of error responses.

@rzikm rzikm self-assigned this Jan 17, 2024
@ghost

ghost commented Jan 17, 2024

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds tests for getting OCSP staple to send in TLS handshake, including testing staple refresh and correct handling of error responses.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net.Security
Milestone: -

@rzikm

rzikm commented Jan 17, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelines Bot commented Jan 17, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
rzikm requested review from bartonjs and wfurt January 17, 2024 13:49
This was referenced Jan 17, 2024
Closed
Closed
Closed
Open
Closed
Closed
Open
@rzikm
rzikm requested a review from bartonjs January 19, 2024 09:50
@rzikm

rzikm commented Jan 25, 2024

Copy link
Copy Markdown
Member Author

@bartonjs, @wfurt PTAL.

wfurt
wfurt approved these changes Jan 29, 2024
View reviewed changes

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@build-analysis build-analysis Bot mentioned this pull request Jan 30, 2024
Closed
@rzikm

rzikm commented Jan 31, 2024

Copy link
Copy Markdown
Member Author

CI Failures are known build errors.

@rzikm
rzikm merged commit 9429e43 into dotnet:main Jan 31, 2024
@rzikm rzikm mentioned this pull request Jan 31, 2024
Closed
@filipnavara filipnavara mentioned this pull request Jan 31, 2024
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes
@bartonjs bartonjs Awaiting requested review from bartonjs

Assignees

@rzikm rzikm

Labels

area-System.Net.Security

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rzikm @bartonjs @wfurt @karelz