Skip to content

add VB samples zip file - #5

Merged
BillWagner merged 1 commit into
dotnet:masterfrom
BillWagner:add-vb-zip-file
Apr 2, 2018
Merged

BillWagner merged 1 commit into
dotnet:masterfrom
BillWagner:add-vb-zip-file

Conversation

@BillWagner

Copy link
Copy Markdown
Member

Noticed when we split the repos.

Noticed when we split the repos.
@mairaw

mairaw commented Apr 2, 2018

Copy link
Copy Markdown
Contributor

Thanks @BillWagner.

I also had a question on why the vb folder had fewer files than the c# one. Take a look:
https://github.com/dotnet/samples/tree/master/snippets/visualbasic/how-to/conversions
https://github.com/dotnet/samples/tree/master/snippets/csharp/how-to/conversions

By design?

@BillWagner

Copy link
Copy Markdown
Member Author

@mairaw That's by accidental design. 🤔 I started the C# ones thinking more might end up in the program. It didn't.

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then 😆

@BillWagner
BillWagner merged commit 3d83bbc into dotnet:master Apr 2, 2018
@BillWagner
BillWagner deleted the add-vb-zip-file branch April 12, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants