Conversation
safe.transactions_all listed safe_mantle_transactions twice since duneanalytics#6942 (mantle had already been added in duneanalytics#6777), so every Mantle Safe transaction appeared twice in the union. Remove the second ref. While here, include the chains that have per-chain Safe models but were never added to the umbrella views: berachain and ronin in transactions_all, ronin in native_transfers_all. safe_safes_all already had both. Update the blockchain metadata in safe_schema.yml to match (also drops a stray empty entry in the safes_all list).
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
kriss39
marked this pull request as ready for review
September 13, 2026 13:17
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
safe.transactions_allhas listedsafe_mantle_transactionstwice since #6942 (Mantle was already in the list from #6777), so every Mantle Safe transaction appears twice in the union view. This removes the duplicate ref.While in the file I also added the chains that have per-chain Safe models but were never included in the umbrella views:
safe_berachain_transactionsandsafe_ronin_transactions→safe.transactions_allsafe_ronin_eth_transfers→safe.native_transfers_allsafe.safes_allalready had both chains. The per-chain models are generated from the same macros as the chains already in the union, so the column lists line up.safe_schema.ymlblockchain metadata updated to match (it also had a stray empty entry in thesafes_alllist).All three models are views, so no backfill is needed.