Repository navigation
[Draw2D] Simplify disablement of repaint logic in FigureCanvas - #1674
Merged
ptziegler merged 1 commit intoNov 1, 2026
Merged
Conversation
ptziegler
force-pushed
the
draw2d-repaint-canvas
branch
from
October 28, 2026 20:05
0e219f9 to
75940e7
Compare
ptziegler
force-pushed
the
draw2d-repaint-canvas
branch
3 times, most recently
from
October 29, 2026 06:37
7b70258 to
28e9e70
Compare
Rather than setting an explicit flag that draws a cached image onto the canvas, it should be sufficient to simply prevent the images from being painted by turning them invisible. Note that it's not possible to suppress the redraw event by setting `setRedraw(false)` on the `FigureCanvas`, as a paint event might still be forced by the native code called in the `OSSupport` implementation. One such example being `gtk_widget_show_now`.
ptziegler
force-pushed
the
draw2d-repaint-canvas
branch
from
November 1, 2026 15:36
28e9e70 to
758f0e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than setting an explicit flag that draws a cached image onto the canvas, it should be sufficient to simply disable paint events via the
setRedraw()method.