Repository navigation
Serialize MDC under top level - #67
Merged
Merged
Conversation
Makes it easier to set ECS fields via MDC. Previously, you'd have to configure topLevelLabels for each ECS field added via MDC. Now, if you want to have a field nested under labels, you have to explicitly prefix it with `labels.`.
Member
Author
|
@pgomulka would this break anything in Elasticsearch? |
xeraa
approved these changes
Mar 31, 2020
xeraa
left a comment
Member
There was a problem hiding this comment.
Took a quick look and I think this makes a lot of sense (also in documenting how to use this)
Contributor
@felixbarny ES is not using MDC, so should be safe. |
|
With this change, I'm having a problem with collecting log with Filebeat. It's because some library produce 'url' MDC which is one of ECS key, and the formate is not compatible with ECS(or Elasticsearch) Here is example value of 'url' MDC, and I got error when I collect this log with Filebeat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier to set ECS fields via MDC.
Previously, you'd have to configure
topLevelLabelsfor each ECS field added via MDC.Now, if you want to have a field nested under labels, you have to explicitly prefix it with
labels..This increases the chance of conflicts, for example when the user adds an
@timestampMDC value. But it also gets out of the way for legitimate use cases.Having to whitelist all MDC values that should be serialized at the top level via
topLevelLabelsis cumbersome and feels inconsistent. I think it's overly protective.