Skip to content

Preserve negotiated chat roles through model execution - #75

Merged
andersalm merged 1 commit into
feat/0.7.1-modelsfrom
feat/0.7.1-model-chat-roles
Sep 29, 2026
Merged

andersalm merged 1 commit into
feat/0.7.1-modelsfrom
feat/0.7.1-model-chat-roles

Conversation

@andersalm

@andersalm andersalm commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Assistant flattened each conversation into one prompt. It now sends ordered system, user, and assistant messages when the selected text offer advertises elastos.model.input.text/v2. Runtime binds the complete message array, and the provider forwards it unchanged to the chat engine. Older offers and Responses offers retain their v1 prompt path.

Schema capabilities pass through local and shared offers. They stay outside the execution revision so retained v1 terminal, active, and uncertain runs keep their recorded authority. Adapter, route, model, and policy changes still alter that revision. Readiness and retirement accept validated capability metadata while comparing execution identity and policy exactly. Marketplace receives the regenerated Assistant contract module.

Depends on #72 (feat/0.7.1-models). Merge after or with that parent and reconcile if the parent moves.

Validation:

  • Completed the required local gate in stages: source/UI/entropy/vendor and command checks, release candidate audit, corrected workspace formatting and strict Clippy, all workspace/capsule tests, and Browser local-exit formatting/lint/tests.
  • Provider: 228 unit tests and six process tests passed; two existing exact-model tests remain ignored. Tests capture engine messages, trace real offers through Assistant negotiation, preserve old journals, and prove uncertain retries do not dispatch again.
  • Mac broker: exact v2 messages pass; changed roles, order, content, fields, schema use, and token limits fail. Existing v1 chat and Responses checks pass. Full server suite: 2,242 passed, 20 existing ignored.
  • Independent source review and the equivalent validator lint correction were accepted.
  • All eight required CI checks passed, including the Mac and both Linux source-home jobs: CI run 36521550976.

Validation uses local fixtures. Installed-model comparison remains a later task.

@irzhywau irzhywau added this to the 0.7.1 milestone Sep 29, 2026
@andersalm
andersalm marked this pull request as ready for review September 29, 2026 12:32
@andersalm
andersalm merged commit 968ad0e into feat/0.7.1-models Sep 29, 2026
9 checks passed
This was referenced Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants