Skip to content

Fix stale global search result badges - #1822

Merged
jeremypw merged 10 commits into
elementary:masterfrom
kahhong:master
Oct 6, 2026
Merged

jeremypw merged 10 commits into
elementary:masterfrom
kahhong:master

Conversation

@kahhong

@kahhong kahhong commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Fixes (#1672) by clearing all global search result badges in the sidebar when the searched text changes.

@zeebok
zeebok requested a review from a team September 21, 2026 04:23
jeremypw
jeremypw previously approved these changes Sep 21, 2026

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job thanks!

I'll hold this back from merging until the pending release (8.4.0) goes out so that does not have to be revised.

@jeremypw jeremypw added the Status: Blocked Something else needs to be done before this can be fixed label Sep 21, 2026
@jeremypw

Copy link
Copy Markdown
Collaborator

Blocked unto v 8.4.0 goes out.

IhorHordiichuk and others added 8 commits October 3, 2026 13:53
Currently translated at 96.7% (265 of 274 strings)

Translation: Code/Code
Translate-URL: https://l10n.elementaryos.org/projects/code/code/uk/
Currently translated at 100.0% (136 of 136 strings)

Translation: Code/Extra
Translate-URL: https://l10n.elementaryos.org/projects/code/extra/ru/
Currently translated at 100.0% (274 of 274 strings)

Translation: Code/Code
Translate-URL: https://l10n.elementaryos.org/projects/code/code/uk/
Currently translated at 75.7% (103 of 136 strings)

Translation: Code/Extra
Translate-URL: https://l10n.elementaryos.org/projects/code/extra/uk/
Currently translated at 81.6% (111 of 136 strings)

Translation: Code/Extra
Translate-URL: https://l10n.elementaryos.org/projects/code/extra/uk/
* Simply search function

* Lose unused has_matches ()

---------

Co-authored-by: Ryan Kornheisl <ryan@skarva.tech>
@zeebok
zeebok requested a review from jeremypw October 4, 2026 17:04

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@jeremypw
jeremypw merged commit 07ba77b into elementary:master Oct 6, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Blocked Something else needs to be done before this can be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global search should clear badges as soon as the related search term is deleted or changed

5 participants