Repository navigation
ci: support Pro in release-tag-creation action [ED-25747] - #60
Merged
Merged
Conversation
Replace plugin_file, version_constant, update_readme and update_elementor_tested_up_to with a single required plugin input (core | pro). Pro bumps elementor-pro.php / ELEMENTOR_PRO_VERSION and sets the "Elementor tested up to" header from Core release/<channel>; Core keeps bumping elementor.php and readme.txt. Co-authored-by: Cursor <cursoragent@cursor.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
…25747] Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
max-zu
previously approved these changes
Oct 6, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
Co-authored-by: Cursor <cursoragent@cursor.com>
2 of 12 tasks
Ntnelbaba
reviewed
Oct 7, 2026
Ntnelbaba
left a comment
Contributor
There was a problem hiding this comment.
Review
Re-checked at df341e32 (not from zero).
Still open:
- Medium —
fetchCoreReleaseVersionraw.githubusercontent fetch has no cache-bust (inline). - Low —
plugin_file/update_readmeoutputs are set before the PHP write succeeds (inline). - Low — no unit/integration test for
run()inupdate-version-files.ts.
plugin default core, plugin-config mapping, and throw-on-missing header/define behavior look good.
Comment-only; not approving.
…ut after file writes, add tests [ED-25747] Co-authored-by: Davids Seveloff <davseve@users.noreply.github.com>
…oduction risk [ED-25747] Co-authored-by: Davids Seveloff <davseve@users.noreply.github.com>
Ntnelbaba
approved these changes
Oct 8, 2026
| maintain_email: | ||
| required: true | ||
| description: 'Git user.email for the version-bump commit.' | ||
| plugin: |
Contributor
There was a problem hiding this comment.
And if the value is "koko"?
Ntnelbaba
disabled auto-merge
October 8, 2026 09:18
davseve
added a commit
that referenced
this pull request
Oct 11, 2026
Address code review comment from PR #60: validate the plugin input ('core' or 'pro') in the 'Handle version input' step before any git branch operations occur. This ensures invalid plugin values like 'koko' fail fast with a clear error message, preventing wasted work and avoiding branch checkout mutations. Changes: - Import and call resolvePluginConfig() at the start of main.ts run() - Add INPUT_PLUGIN env var to 'Handle version input' step in action.yml - Add getPlugin() helper to read INPUT_PLUGIN (defaults to 'core') - Add unit tests for plugin validation behavior - Extend plugin-config.test.ts to explicitly test 'koko' case Ref: #60 Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Davids Seveloff <davseve@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets the
release-tag-creationaction release Elementor Pro as well as Core, selected by one new input.New input
plugin: core | pro(defaultcore). It replacesplugin_file,version_constant,update_readmeandupdate_elementor_tested_up_to. The mapping is inplugin-config.ts:plugincoreelementor.phpELEMENTOR_VERSIONproelementor-pro.phpELEMENTOR_PRO_VERSIONrelease/<channel>Pro "Elementor tested up to". The action fetches
elementor.phpfrom Core's matchingrelease/<channel>branch, reads itsVersion:and writes it asX.Y.Z, with any beta suffix removed (elementor-tested-up-to.ts).Shared utils (
version-files.ts).patchPhpVersiontakes the constant to update, typed asVersionConstant(ELEMENTOR_VERSIONorELEMENTOR_PRO_VERSION). A newpatchPhpHeaderFieldupdates any* Field: valueheader line. Both now throw if the expected line is missing, instead of silently committing an unchanged file.The commit step and the job summary now read
plugin_fileandupdate_readmefrom the version-update step's outputs, not from inputs.Compatibility
plugindefaults tocore, which matches the old defaults (elementor.php,ELEMENTOR_VERSION, readme updated).plugin: pro. If it's forgotten, the run fails readingelementor.php, which doesn't exist in the Pro repo, before anything is committed or tagged.Testing
vitestinactions/release-tag-creationandpackages/editor-github-actions-utilspasses.tscandeslintare clean.✨ PR Description
1. Problem & Context
Extends the
release-tag-creationaction to support Elementor Pro ED-25747. This enables automated version bumping for Pro and synchronizes the "Elementor tested up to" header with the latest Core release version.2. What Changed (Where)
elementor-tested-up-to.tsplugin-config.tsupdate-version-files.tsrun()to handle dynamic plugin config and header patching.version-files.ts@elementor/editor-github-actions-utils.action.ymlpluginandgithub_tokeninputs; updated outputs and commit logic.*.test.ts3. How It Works
The action now accepts a
plugininput ('core' or 'pro'). For 'pro', it fetches the current version of the specified Core channel (stable/beta) using the GitHub Contents API, strips pre-release tags viasemver, and patches both theELEMENTOR_PRO_VERSIONconstant and the "Elementor tested up to" header inelementor-pro.php.4. Risks
API rate limits on Core version fetching; mitigated by the optional
github_tokeninput.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how