You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
so to be honest I think there was too much stuff included in the last release 🤔 I didn't expect anything other than fastboot-app-server to be released since it's downstream from fastboot and ember-cli-fastboot
i didn't investigate since it was such a small issue I didn't think it mattered
@mansona as far as I see, it publishes everything because release-plan pin dependencies to specific version (or maybe it's pnpm) when the package or it's dependencies within monorepo gets bumped/published.
because of the typo fixed in this PR, fastboot-express-middleware was not bumped and published in previous releases.
As a result, latest https://www.npmjs.com/package/ember-cli-fastboot?activeTab=code points to "fastboot": "4.1.5" and "fastboot-express-middleware": "4.1.2"
SergeAstapov
changed the title
Fix workspace protocol for fastboot-express-middleware package
Fix workspace protocol to use caret to avoid unnecessary duplication
Oct 11, 2024
@mansona this was updated according to discussion in #951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mansona I guess this is the reason why
fastboot-express-middlewarewas not included in latest release https://github.com/ember-fastboot/ember-cli-fastboot/releases/tag/v4.1.5-ember-cli-fastbootCloses #951