Repository navigation
Delete obsolete SIMD.js support - #11180
Conversation
tlively
left a comment
There was a problem hiding this comment.
I suspect that there is a bunch more legacy SIMD support code that needs to be deleted as well, but this is definitely an improvement 👍
|
Re-requesting reviews: expanded this PR to drop the SIMD.js paths. Also removed -s SIMD=1 setting, now just -msimd128 remains. |
kripken
left a comment
There was a problem hiding this comment.
lgtm module the new internal flag, see comment.
About the test removals, is it not worth converting some of them for the new simd?
| var BINARYEN_FEATURES = []; | ||
|
|
||
| // Tracks whether to enable Wasm SIMD support in Binaryen. | ||
| var BINARYEN_SIMD = 0; |
There was a problem hiding this comment.
Why is this needed? I think it should work automatically with BINARYEN_FEATURES like other wasm features. Maybe I'm forgetting something @tlively ?
There was a problem hiding this comment.
It does not seem to. Not sure if it's not hooked up, or?
There was a problem hiding this comment.
That could be a bug in LLVM then if it isn't writing out the simd feature @tlively ?
There was a problem hiding this comment.
Yeah this should Just Work™️. I can look into it as a follow-up.
It might be, but I don't have the cycles to research that. There do already exist wasm simd tests, not sure how complete those are. |
|
@tlively this doc should be updated too? https://docs.google.com/document/d/1oy_bYCtMBIqhxhPTVpWgQFygazKL2FVwILaf3BrcacQ/edit |
|
I think that doc has probably been superseded by the official Emscripten documentation, but I'll update it to point to the right place. |
Delete obsolete SIMD.js support.